Compare Operator #5325
Merged
Compare Operator #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
reviewed
Nov 2, 2017
paddle/operators/compare_op.cc
Outdated
| }; | ||
|
|
||
| template <typename OpComment> | ||
| class LogicalOpInferShape : public framework::InferShapeBase { |
paddle/operators/compare_op.cc
Outdated
| namespace paddle { | ||
| namespace operators { | ||
| template <typename OpComment> | ||
| class LogicalOpProtoMaker : public framework::OpProtoAndCheckerMaker { |
There was a problem hiding this comment.
Maybe BinaryLogicalOpProtoMaker is more accurate.
reyoung
force-pushed
the
feature/logical_op
branch
from
7e8ace7
to
f9ef2fb
Compare
| PADDLE_ENFORCE(context->HasInput("X"), "%s operator must has input X", | ||
| comment.type); | ||
| PADDLE_ENFORCE(context->HasInput("Y"), "%s operator must has input Y", | ||
| comment.type); |
There was a problem hiding this comment.
enforce X and Y to have the same shape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator
less_thanandequal