【Hackathon 4th No.26】为 Paddle 新增 paddle.sparse.nn.Softmax 稀疏 API 的 coo 格式计算逻辑 #53613

thunder95 · 2023-05-08T16:48:47Z

PR types

New features

PR changes

APIs

Description

针对 Paddle 的稀疏 Tensor 格式 COO，需要新增 softmax 的计算逻辑.

RFC设计文档: PaddlePaddle/community#514
中文api文档:

… develop

…velop

… develop

…velop

… develop

…velop

… develop

…velop

… develop

… softmax_sparse

paddle-bot · 2023-05-08T16:48:51Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-ci-bot · 2023-05-18T03:14:27Z

Sorry to inform you that 8a7b606's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

paddle/phi/kernels/sparse/cpu/softmax_kernel.cc

paddle/phi/kernels/funcs/sparse/softmax.cu.h

paddle/phi/kernels/funcs/sparse/softmax.h

… softmax_sparse

zkh2016 · 2023-05-23T12:21:16Z

CI-Coverage没过，还需要补充些单测

… softmax_sparse

thunder95 · 2023-05-24T00:54:21Z

CI-Coverage没过，还需要补充些单测

@zkh2016 在反向时，参考torch实现，有一种情况out_offsets != grad_offsets没有覆盖到，但是现在测试时，始终out_offsets==grad_offsets, 因为out和dout的indices是一样的。麻烦老师给个建议，是否可以删掉这个if分支，或者有没有其他办法可以单独测试这个反向并可以制定反向输入的参数。

zkh2016 · 2023-05-24T02:39:12Z

CI-Coverage没过，还需要补充些单测

@zkh2016 在反向时，参考torch实现，有一种情况out_offsets != grad_offsets没有覆盖到，但是现在测试时，始终out_offsets==grad_offsets, 因为out和dout的indices是一样的。麻烦老师给个建议，是否可以删掉这个if分支，或者有没有其他办法可以单独测试这个反向并可以制定反向输入的参数。

行，这个可以先豁免下。

不过看了下反向的kernel好像没优化，看上去应该和前向差不多思路就行，要不也试试优化看？

… softmax_sparse

thunder95 · 2023-05-24T10:43:49Z

CI-Coverage没过，还需要补充些单测

@zkh2016 在反向时，参考torch实现，有一种情况out_offsets != grad_offsets没有覆盖到，但是现在测试时，始终out_offsets==grad_offsets, 因为out和dout的indices是一样的。麻烦老师给个建议，是否可以删掉这个if分支，或者有没有其他办法可以单独测试这个反向并可以制定反向输入的参数。

行，这个可以先豁免下。

不过看了下反向的kernel好像没优化，看上去应该和前向差不多思路就行，要不也试试优化看？

谢谢老师，已修改 @zkh2016

sunzhongkai588

LGTM for docs

jeff41404

LGTM

luotao1 · 2023-05-25T06:39:21Z

@thunder95 请补充下中文文档

thunder95 added 25 commits February 20, 2023 16:32

untracked files

c8ae296

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

6aa02f0

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d599110

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

264894d

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

98d1e1c

… develop

Merge branch 'develop' of https://github.com/thunder95/Paddle into de…

b958122

…velop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

760e099

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

e16076d

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

085c7a6

… develop

Merge branch 'develop' of https://github.com/thunder95/Paddle into de…

b1edf68

…velop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

f2887e5

… develop

Merge branch 'develop' of https://github.com/thunder95/Paddle into de…

6a62308

…velop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

6620e88

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

e4134d9

… develop

merge

8659385

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

9f7f271

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

b1fc28f

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

cff3cd2

… develop

Merge branch 'develop' of https://github.com/thunder95/Paddle into de…

aa0713b

…velop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

065fcb4

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

f7007ea

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

f875704

… develop

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

8339831

… softmax_sparse

softmax coo kernel

3f97f35

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

5c19dc6

… softmax_sparse

paddle-bot bot added the contributor External developers label May 8, 2023

thunder95 mentioned this pull request May 9, 2023

【PaddlePaddle Hackathon 第四期】任务总览 #51281

Closed

luotao1 assigned luotao1 and zkh2016 May 9, 2023

add comments

f54e621

thunder95 requested a review from zkh2016 May 18, 2023 02:56

zkh2016 reviewed May 18, 2023

View reviewed changes

paddle/phi/kernels/sparse/cpu/softmax_kernel.cc Outdated Show resolved Hide resolved

thunder95 added 2 commits May 19, 2023 01:24

extract common func

4fc3e4f

optimize softmax kernel

fa8806f

thunder95 requested a review from zkh2016 May 21, 2023 08:12

zkh2016 reviewed May 23, 2023

View reviewed changes

paddle/phi/kernels/funcs/sparse/softmax.cu.h Outdated Show resolved Hide resolved

paddle/phi/kernels/funcs/sparse/softmax.h Outdated Show resolved Hide resolved

thunder95 added 2 commits May 23, 2023 09:23

fix copyright year

e7188fa

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

56533fa

… softmax_sparse

thunder95 added 3 commits May 23, 2023 15:01

add device test in unittest

850a133

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

1317e45

… softmax_sparse

fix backward checking

94e3159

thunder95 requested a review from zkh2016 May 24, 2023 00:15

thunder95 added 3 commits May 24, 2023 06:59

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

fd5486b

… softmax_sparse

optimize grad cu

fa948ee

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

aeb66a4

… softmax_sparse

zkh2016 approved these changes May 25, 2023

View reviewed changes

luotao1 assigned jeff41404 and sunzhongkai588 May 25, 2023

luotao1 added the API label May 25, 2023

sunzhongkai588 approved these changes May 25, 2023

View reviewed changes

jeff41404 approved these changes May 25, 2023

View reviewed changes

tianshuo78520a approved these changes May 25, 2023

View reviewed changes

luotao1 merged commit 4ea1d04 into PaddlePaddle:develop May 25, 2023
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 4th No.26】为 Paddle 新增 paddle.sparse.nn.Softmax 稀疏 API 的 coo 格式计算逻辑 #53613

【Hackathon 4th No.26】为 Paddle 新增 paddle.sparse.nn.Softmax 稀疏 API 的 coo 格式计算逻辑 #53613

thunder95 commented May 8, 2023 •

edited by luotao1

paddle-bot bot commented May 8, 2023

paddle-ci-bot bot commented May 18, 2023

zkh2016 commented May 23, 2023

thunder95 commented May 24, 2023

zkh2016 commented May 24, 2023

thunder95 commented May 24, 2023

sunzhongkai588 left a comment

jeff41404 left a comment

luotao1 commented May 25, 2023

【Hackathon 4th No.26】为 Paddle 新增 paddle.sparse.nn.Softmax 稀疏 API 的 coo 格式计算逻辑 #53613

【Hackathon 4th No.26】为 Paddle 新增 paddle.sparse.nn.Softmax 稀疏 API 的 coo 格式计算逻辑 #53613

Conversation

thunder95 commented May 8, 2023 • edited by luotao1

PR types

PR changes

Description

paddle-bot bot commented May 8, 2023

paddle-ci-bot bot commented May 18, 2023

zkh2016 commented May 23, 2023

thunder95 commented May 24, 2023

zkh2016 commented May 24, 2023

thunder95 commented May 24, 2023

sunzhongkai588 left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

luotao1 commented May 25, 2023

thunder95 commented May 8, 2023 •

edited by luotao1