Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in log_softmax kernel when lastdim is larger than 100000 #53654

Merged
merged 1 commit into from May 10, 2023
Merged

Fix bug in log_softmax kernel when lastdim is larger than 100000 #53654

merged 1 commit into from May 10, 2023

Conversation

ZzSean
Copy link
Contributor

@ZzSean ZzSean commented May 9, 2023

PR types

Bug fixes

PR changes

OPs

Description

Fix bug in log_softmax kernel when lastdim is larger than 100000

There is an unexpected log in the calculation

@paddle-bot
Copy link

paddle-bot bot commented May 9, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 9, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

This was referenced May 9, 2023
Closed
Merged
Merged
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators May 9, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation May 9, 2023
lanxianghit pushed a commit that referenced this pull request May 10, 2023
@ZzSean
[Cherry-Pick] Fix bug in log_softmax kernel when lastdim is larger th…
a7cad38 
…an 100000 (#53657)

Fix bug in log_softmax kernel when lastdim is larger than 100000

There is an unexpected log in the calculation

Cherry-Pick: #53654
Xreki
Xreki approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit 0f319f8 into PaddlePaddle:develop May 10, 2023
22 of 24 checks passed
@ZzSean ZzSean deleted the fix_logsoftmax branch July 13, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZzSean @Xreki