Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two minor issues in 'dim_simplier. h' #53658

Merged
merged 2 commits into from May 10, 2023

Conversation

WintersMontagne10335
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Description

#53488 中提到的:
一是,ExtendInputDimensions的参数int N应该可以删掉,函数中并没有使用该参数;
二是,根据上下文逻辑,123行代码中的axis应该修改为out_idx。

@paddle-bot
Copy link

paddle-bot bot commented May 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 9, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 9, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@WintersMontagne10335 WintersMontagne10335 changed the title Winters001 Fix two minor issues in 'dim_simplier. h' May 9, 2023
@Xreki Xreki requested a review from JamesLim-sy May 10, 2023 02:49
Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@JamesLim-sy JamesLim-sy merged commit ee1aa69 into PaddlePaddle:develop May 10, 2023
22 of 24 checks passed
@luotao1
Copy link
Contributor

luotao1 commented May 10, 2023

hi, @WintersMontagne10335

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

@WintersMontagne10335 WintersMontagne10335 deleted the winters001 branch May 17, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants