Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Werror][GCC9] fix -Werror=format-security #53886

Merged
merged 1 commit into from
May 18, 2023

Conversation

engineer1109
Copy link
Contributor

@engineer1109 engineer1109 commented May 17, 2023

PR types

Bug fixes

PR changes

Others

Description

GCC9遇到如下编译Werror

/media/wjl/D2/github/fork/10/Paddle/paddle/fluid/inference/tensorrt/convert/generic_and_custom_plugin_creater.cc: In member function ‘virtual void paddle::inference::tensorrt::CustomPluginCreater::operator()(const paddle::framework::proto::OpDesc&, const paddle::framework::Scope&, bool)’:
/media/wjl/D2/github/fork/10/Paddle/paddle/fluid/inference/tensorrt/convert/generic_and_custom_plugin_creater.cc:81:77: error: format not a string literal and no format arguments [-Werror=format-security]
   81 |           plugin_attr_name.data(), attr_name.length() + 1, attr_name.c_str());

对于

      snprintf(
          plugin_attr_name.data(), attr_name.length() + 1, attr_name.c_str());

这样是不合理的。必须有"%s"这样的字符串表达式,作为第三个参数,而不是变量attr_name.c_str()

修改如下:

      snprintf(plugin_attr_name.data(),
               attr_name.length() + 1,
               "%s",
               attr_name.c_str());

@paddle-bot
Copy link

paddle-bot bot commented May 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 17, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 17, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@engineer1109
Copy link
Contributor Author

#47143
@luotao1

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 6d7076c into PaddlePaddle:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants