Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] format the use of new ir api #54356

Merged
merged 1 commit into from Jun 5, 2023

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Jun 5, 2023

PR types

Others

PR changes

APIs

Description

规范化新IR的接口。

  • 将create、destroy、build等api的首字母大写。
  • 按照设计,Create和Build的区别在于Create的返回值需要调用者显式的destroy. 而Build的返回值则不需要。
    • 基于此原则,将ir::Builder中的Create接口修改为Build。因此Builder会自动将创建的Operation插入相应的插入点。不需要用户显式Destroy。
  • 删除新Op定义中的Build函数的第一个参数Builder, 因为该函数的实现并不需要用到该参数。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Jun 5, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@winter-wang winter-wang force-pushed the ir_develop_2 branch 8 times, most recently from 2fe22a0 to ede8007 Compare June 5, 2023 11:57
@winter-wang winter-wang merged commit ea89e96 into PaddlePaddle:develop Jun 5, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants