Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【第三方库离线编译】Delete concurrentqueue cmake #54438

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Jun 7, 2023

PR types

Others

PR changes

Others

Description

因为Paddle主框架并没有用到concurrentqueue第三方库,只有PaddleCustomDevice的mluconcurrentqueue依赖,而且目前Paddle做了寒武纪相关代码退场,目前认为这个是遗留代码,考虑将其移动到PaddleCustomDevice.

@paddle-bot
Copy link

paddle-bot bot commented Jun 7, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 7, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 8, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 27, 2023

Sorry to inform you that 3a7845a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Jun 28, 2023

@risemeup1 帮忙review一下~

Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit f7bdd18 into PaddlePaddle:develop Jun 28, 2023
23 of 25 checks passed
@ccsuzzh ccsuzzh deleted the delete_concurrentqueue_cmake branch June 30, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants