Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] [Baby step] New interprector support new ir #54570

Merged
merged 45 commits into from
Jun 15, 2023

Conversation

phlrain
Copy link
Collaborator

@phlrain phlrain commented Jun 12, 2023

PR types

Others

PR changes

Others

Description

打通新执行器和新IR

这是一个非常基础的版本,旨在打通整体流程,加大并发量,包含但不限于后续的要完善的功能

  1. data transform
  2. inplace
  3. no need buffer
  4. gc
  5. build context 完善
  6. ...

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Jun 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Jun 12, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@phlrain
Copy link
Collaborator Author

phlrain commented Jun 13, 2023

这个PR合入以后,如果不编译新IR, paddle代码应该就无法编译成功了吧。那是不是可以把Option里面的WITH_IR直接给删了,直接强制编译新IR。

可以的

interpreter
interpretercore_garbage_collector
workqueue
new_ir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_ir 作为最基础的 target,是不是应该放在最后

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

::ir::BuildScope(
ir_program_->block(), local_scope_, &value_2_var_name_map_);
} else {
paddle::framework::interpreter::BuildVariableScope(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paddle::framework::interpreter::BuildVariableScope(
interpreter::BuildVariableScope(

这里其实不需要加paddle::framework 的,太长了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for new flag

@phlrain phlrain merged commit ce0c5c2 into PaddlePaddle:develop Jun 15, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet