[IR&PASS] part 3-3: Add PatternRewrite Driver code. #54738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiweibo
commented
Jun 19, 2023
jiweibo
changed the title
jiweibo
commented
Jun 19, 2023
jiweibo
commented
Jun 19, 2023
jiweibo
commented
Jun 19, 2023
jiweibo
commented
Jun 25, 2023
|
|
||
| bool MatchAndRewrite(paddle::dialect::TransposeOp op, | ||
| ir::PatternRewriter &rewriter) const override { | ||
| auto prev_op = op->operand(0).source().GetDefiningOp(); |
There was a problem hiding this comment.
确实，这个写法好像比较常见，我回头封装个接口吧
There was a problem hiding this comment.
op->operand(0)和op.x()是不是等价的？更推荐哪种写法呢？
There was a problem hiding this comment.
C++写法 op.x()可以，生成的话一般是operand(0)
There was a problem hiding this comment.
x对应的是算子的输入的名字，是跟具体算子类型相关的。operand(0)对应的是输入的index，是通用接口。
jiweibo
commented
Jun 25, 2023
| auto new_perm = GetPerm(axis_first, axis_last); | ||
| rewriter.SetInsertionPoint(op); | ||
| auto new_op = rewriter.Build<paddle::dialect::TransposeOp>( | ||
| prev_op->operand(0).source().GetDefiningOp()->result(0), new_perm); |
jiweibo
commented
Jun 25, 2023
yuanlehome
reviewed
Jun 25, 2023
|
|
||
| namespace ir { | ||
|
|
||
| /// This enum will control which ops will be added to the worklist during the |
There was a problem hiding this comment.
后面这些注释都用两个//吧，没看到有用///的
There was a problem hiding this comment.
文档生成一般用///描述class或函数的作用，后面可以考虑统一下
winter-wang
reviewed
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-71500
新IR下的新PASS体系，新PASS体系适配新IR。该系列PR主要包括如下几个部分：
主要包括四个部分：(1) Pass base & PassManager & PassAdaptor; #54023 (2) AnalysisManager & Pass Instrumentation (PassTiming, IRPrinting..); #54170 #54308 #54348 (3) Pattern Rewrite ... #54385 #54492 (4) 其他。
本PR完成第3部分包括：