[IR] Refactor op yaml info parser #54790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactor_op_info
… refactor_op_info
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
Aurelius84
reviewed
Jun 20, 2023
| std::vector<std::pair<std::string, std::string>> inplace; | ||
| std::vector<std::pair<std::string, std::string>> view; | ||
| OpRunTimeInfo(std::string infer_meta_func, | ||
| std::vector<std::string> infer_meta_param, |
| bool no_need_buffer = false; | ||
| bool is_mutable_attribute = false; | ||
| OpInputInfo() {} | ||
| OpInputInfo(const OpInputInfo& input_info) |
There was a problem hiding this comment.
OpInputInfo(const OpInputInfo& input_info)=default;
|
|
||
| const OpInfoTuple& op_info_tuple_; | ||
|
|
||
| const std::vector<OpInputInfo>& vec_op_input_info_; |
There was a problem hiding this comment.
这个成员是不是只是op_info_tuple_ 第0个位置的vector。这里可以不作为类成员，而是以 private inline const & InputInfo() const 形式来内部使用即可？
… refactor_op_info
… refactor_op_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
新增Op yaml infor的parser，方便在lowering 和构造context的时候使用，减少重复代码
Other
Pcard-67164