Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XPU][PHI Kernels] add int_with_ll quantization for conv kernels #54827

Merged
merged 2 commits into from
Jun 28, 2023
Merged

[XPU][PHI Kernels] add int_with_ll quantization for conv kernels #54827

merged 2 commits into from
Jun 28, 2023

Conversation

lj970926
Copy link
Contributor

@lj970926 lj970926 commented Jun 23, 2023 •
edited
Loading

PR types

New features

PR changes

OPs

Description

  1. 为xpu卷积相关kernel添加int_with_ll量化支持，主要包括以下kernel:
    a. conv2d
    b. conv2d_grad
    c. conv3d
    d. conv3d_grad
    e. conv2d_tranpose
  2. conv2d_tranpose_v2 api目前暂不支持int_with_ll量化，对该量化方式调用xpu::conv2d_transpose，但用户自己指定output_size时（极少数情况），可能与该api算出的维度不一致（可参考单测中的XPUTestConv2DTransposeOp.TestWithEvenUpsample），因此对该情况禁用int_with_ll量化。
  3. deformable conv前向及反向算子不支持int_with_ll量化
  4. conv2d_transpose_grad的int_with_ll支持已在前序PR中实现。 [XPU][PHI Kernels] add int quantization for xpu conv2d_transpose_grad #54802

@paddle-bot
Copy link

paddle-bot bot commented Jun 23, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 23, 2023
QingshuChen
QingshuChen reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@QingshuChen QingshuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit bd67209 into PaddlePaddle:develop Jun 28, 2023
24 of 25 checks passed
@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QingshuChen QingshuChen QingshuChen left review comments

@houj04 houj04 houj04 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lj970926 @QingshuChen @houj04