Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on rocm4.5/rocm5 on ubuntu18.04 #55076

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

onepick
Copy link
Contributor

@onepick onepick commented Jul 3, 2023

PR types

Bug fixes

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Jul 3, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 3, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jul 3, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@onepick
Copy link
Contributor Author

onepick commented Jul 3, 2023

Codestyle-Check中检测出的问题,都是原有代码中的code,这个pr的修改根本没有涉及到这些部分

@luotao1
Copy link
Contributor

luotao1 commented Jul 3, 2023

Copy from https://github.com/skarupke/flat_hash_map
CodeStyle问题,应该把这个文件paddle/utils/flat_hash_map.h(copy from 第三方的)在下面exclude,请 @SigureMo 确认下:

exclude: |
(?x)^(
paddle/cinn/.+|
test/cpp/cinn/.+

@onepick 辛苦一起修复下

@SigureMo
Copy link
Member

SigureMo commented Jul 3, 2023

CodeStyle问题,应该把这个文件paddle/utils/flat_hash_map.h(copy from 第三方的)在下面exclude,请 @SigureMo 确认下:

没有问题,第三方库可以 exclude

如果有多个 Linter 都报错需要放在

# Exclude all third-party libraries and auto-generated files globally
exclude: |
(?x)^(
patches/.+|
paddle/fluid/framework/fleet/heter_ps/cudf/.+|
paddle/fluid/distributed/ps/thirdparty/round_robin.h|
python/paddle/utils/gast/.+|
third_party/.+
)$

如果只有 cpplint 报错,可只在 cpplint 处 exclude,注意增加注释说明是第三方库即可

* declear new rccl api in paddle/fluid
* Fix build error:free(): invalid pointer by pick the fix:
skarupke/flat_hash_map#26
* Filter to check codestyle for flash_hash_map.h

Signed-off-by: jiajuku <jiajuku12@163.com>
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronny1996 ronny1996 merged commit 57cb1c9 into PaddlePaddle:develop Jul 4, 2023
26 of 27 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Jul 4, 2023

hi, @onepick

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

@onepick onepick deleted the fix-rocm branch May 2, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants