remove unused INTEL_MKL_ROOT etc. #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
previously approved these changes
Nov 9, 2017
tensor-tang
reviewed
Nov 9, 2017
cmake/external/openblas.cmake
Outdated
| ELSE() | ||
| ADD_LIBRARY(cblas STATIC ${dummyfile}) | ||
| ENDIF() | ||
| ADD_LIBRARY(cblas STATIC ${dummyfile}) |
There was a problem hiding this comment.
这里应该不能直接这样改，原来用的match，所以把MKL换成MKLML就好，用equal就行。或者直接就可以不需要改这里。
tensor-tang
reviewed
Nov 9, 2017
| @@ -295,38 +295,6 @@ template void vAdd(const int n, const double* a, const double* b, double* r); | |||
|
|
|||
| #endif | |||
|
|
|||
| #ifdef PADDLE_USE_MKL | |||
There was a problem hiding this comment.
这里需要知情下，下面的这些函数，MKLML里面是没有提供的，但是MKL大包里面是提供的。在MKLML时，走的是else的那一路。
emailweixu
reviewed
Nov 9, 2017
| @@ -295,38 +295,6 @@ template void vAdd(const int n, const double* a, const double* b, double* r); | |||
|
|
|||
| #endif | |||
|
|
|||
| #ifdef PADDLE_USE_MKL | |||
| template <> | |||
There was a problem hiding this comment.
具体性能差异还没有测过，但已经发邮件希望MKLML在下一个版本发布时，加入对vInvSqrt/vLog1p/vTanh这三个函数的支持。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4085
As Paddle support MKLML & MKLDNN currently, we could use MKLML to instead INTEL_MKL_ROOT. Setting WITH_MKLML=ON and WITH_MKLDNN=ON, all the MKL related libraries will be auto-downloaded, compiled and installed.