add API for copying data from/to paddle matrix #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
previously approved these changes
Nov 9, 2017
There was a problem hiding this comment.
Thank you for this change!
I am approving this change, and please feel free to merge it.
I would highly recommend adding related GPU/CPU unit tests. Please feel free to add them in this PR, or file another PR after merging this one. I created a reminder as an issue #5528; please remember to add "Fix #5528" text in the PR that fix it. For more details about the test, Github Documentation provides more information.
|
Also adding a corresponding example under |
|
@typhoonzero Sounds good. I've add the example in the recent commit. |
|
@wangkuiyi Thanks. I've add the related units test in the recent commit. |
|
also Fix #5528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5490
使用C-API进行预测时，要求把特征数据拷贝到输入matrix中，当网络推理完成后，需要从输出matrix把结果拷贝出来。目前的C-API只提供了paddle_matrix_set_row函数去逐行设置数据，且不提供数据从matrix拷贝出来的功能。当使用GPU进行推理时，输出matrix的结果保存在GPU中，想从中获取数据尤其麻烦。
本次commit提供了paddle_matrix_set_value/paddle_matrix_get_value, 方便设置和获取matrix的值。