Assign Operator. #5531
Assign Operator. #5531
Conversation
Out=X, when type in [LoDTensor/SelectedRows/LoDTensorArray]
paddle/operators/assign_op.cc
Outdated
|
|
||
| void operator()(const framework::SelectedRows &rows) const { | ||
| auto &out_rows = *out_->GetMutable<framework::SelectedRows>(); | ||
| *out_rows.mutable_rows() = rows.rows(); |
There was a problem hiding this comment.
Why not use set_rows interface https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/framework/selected_rows.h#L45 ?
paddle/operators/assign_op.cc
Outdated
| auto &out_rows = *out_->GetMutable<framework::SelectedRows>(); | ||
| *out_rows.mutable_rows() = rows.rows(); | ||
| auto &t = rows.value(); | ||
| out_rows.mutable_value()->CopyFrom(t, t.place(), dev_ctx_); |
There was a problem hiding this comment.
Whether needs to set height_ for out_rows ? https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/framework/selected_rows.h#L59
paddle/operators/assign_op.cc
Outdated
| return; | ||
| } | ||
| auto *out = scope.FindVar(Output("Out")); | ||
| PADDLE_ENFORCE(out != nullptr, "Must set output if x is set"); |
There was a problem hiding this comment.
Must set output if x is set ->
The Output(Out) should not be null if the Input(X) is set.
paddle/operators/assign_op.cc
Outdated
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput( | ||
| "X", | ||
| "The input variable. Could be LoDTensor/SelectedRows/LoDTensorArray.") |
There was a problem hiding this comment.
" (LoDTensor, SelectedRows or LoDTensorArray) The input variable could be LoDTensor, SelectedRows or LoDTensorArray. "
The most operators' doc follow format: https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/gru_op.cc#L73
() specify the type, then explain it.
paddle/operators/assign_op.cc
Outdated
| "X", | ||
| "The input variable. Could be LoDTensor/SelectedRows/LoDTensorArray.") | ||
| .AsDispensable(); | ||
| AddOutput("Out", "The output variable. Its type will be set as same as X"); |
There was a problem hiding this comment.
" (LoDTensor, SelectedRows or LoDTensorArray) The type of output is the same as input X."
paddle/operators/assign_op.cc
Outdated
| AddOutput("Out", "The output variable. Its type will be set as same as X"); | ||
| AddComment(R"DOC(Assign Operator | ||
|
|
||
| Out = X, when type in [LoDTensor/SelectedRows/LoDTensorArray] |
There was a problem hiding this comment.
tell the user how to process other types?
| class TestAccuracyOp(op_test.OpTest): | ||
| def setUp(self): | ||
| self.op_type = "assign" | ||
| x = numpy.random.random(size=(100, 10)) |
There was a problem hiding this comment.
Here, the input type is LoDTensor. Whether needs to add the unit test to others types?
There was a problem hiding this comment.
Other types of variable are not exposed to Python well. It will be tested during if-else operator's unit tests.
It will be added in the following PRs
| import unittest | ||
|
|
||
|
|
||
| class TestAccuracyOp(op_test.OpTest): |
paddle/operators/assign_op.cc
Outdated
|
|
||
| void operator()(const framework::SelectedRows &rows) const { | ||
| auto &out_rows = *out_->GetMutable<framework::SelectedRows>(); | ||
| *out_rows.mutable_rows() = rows.rows(); |
There was a problem hiding this comment.
Also need to
out_rows.set_height(rows.height());
reyoung
force-pushed
the
feature/assign_op
branch
from
16a7f91
to
15ee123
Compare
Out=X, when type in [LoDTensor/SelectedRows/LoDTensorArray]