Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add split and merge lod tensor operator #5537

Merged
merged 11 commits into from
Nov 14, 2017

Conversation

QiJune
Copy link
Member

@QiJune QiJune commented Nov 10, 2017

Fix #5601

@QiJune QiJune changed the title add split lod tensor operator add split and merge lod tensor operator Nov 13, 2017
@QiJune QiJune requested a review from reyoung November 13, 2017 04:43
@jacquesqiao
Copy link
Member

please add an issue to describe the background of this PR~

@jacquesqiao
Copy link
Member

I think Split/Merge_Lod_Tensor are not good because there are many situations that need to split and merge LoDTensorArray in different ways.

@QiJune
Copy link
Member Author

QiJune commented Nov 13, 2017

@jacquesqiao Yes, it seems that ConditionalFilterOp/ConditionalMergeOp is more accurate. We actually use a mask of bool column vector to filter a LoDTensor. And the LoDTensor is filtered into two parts, true part and false part. Each part will be sent to a separate block.

Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QiJune QiJune merged commit f07a226 into PaddlePaddle:develop Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants