[NewIR]Fix new ir concat split bug #55419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix_new_ir_concat_op
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… fix_new_ir_concat_op
… fix_new_ir_concat_op
… fix_new_ir_concat_op
kangguangli
reviewed
Jul 17, 2023
| @@ -1087,6 +1088,26 @@ struct FetchOpTranscriber : public OpTranscriber { | |||
| } | |||
| }; | |||
|
|
|||
| // NOTE, add_n op in legacy ops don't have a kernel, so we use a new op for now | |||
There was a problem hiding this comment.
我看原本不管外面是不是inplace都会调用同一个kernel实现，这样的话是不是不管 Op的输入输出有没有同一个变量，都把它翻译为非inplace op，然后去掉现在pd_op.yaml里的add_n_下划线版本定义，只对应到一个add_n比较好。
There was a problem hiding this comment.
像这种op有必要区分它们的inplace语义吗？
Aurelius84
reviewed
Jul 17, 2023
| "Only support DenseTensorType in vector")); | ||
| } | ||
| } | ||
| } else if (type.isa<paddle::dialect::AllocatedDenseTensorType>()) { |
There was a problem hiding this comment.
Suggested change
| } else if (type.isa<paddle::dialect::AllocatedDenseTensorType>()) { | |
| } else if (type.isa<paddle::dialect::AllocatedSelectedRowsType>()) { |
这里是写错了？
… fix_new_ir_concat_op
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
* fix new ir concat op bug * fix bug * using add_n_with_kernel instead of add_n impl * fix pd_op yaml bug * fix bug
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
* fix new ir concat op bug * fix bug * using add_n_with_kernel instead of add_n impl * fix pd_op yaml bug * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
修复新IR下， concat split op的单测错误
Others
Pcard-67164