Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] Polish DistTensor details #55436

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Jul 14, 2023

PR types

Function optimization

PR changes

Others

Description

Pcard-73145

[AutoParallel] Polish DistTensor details

  1. 完善了部分日志,关联DistTensor,和其他的有所区分
  2. 注释中命名空间路径补全
  3. DistTensor的initialized和IsInitialized两个接口语义重复但行为不同,将IsInitialized对齐paddle::Tensor改为defined,同时完善了一下检查条件(IsInitialized是fluid Tensor的遗留接口,需要整体删除,不再延续有问题的设计,正在debug中 https://github.com/PaddlePaddle/Paddle/pull/55523)
  4. 完善了个别报错日志和代码实现

@paddle-bot
Copy link

paddle-bot bot commented Jul 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 927c0d5 into PaddlePaddle:develop Jul 19, 2023
26 of 27 checks passed
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
* polish dist_tensor details

* add unittest for coverage

* revert uselesss change

* skip test without dist
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
* polish dist_tensor details

* add unittest for coverage

* revert uselesss change

* skip test without dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants