[OpCompat] add cast and repeat_interleave in op_compat.yaml #55467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@kangguangli Coverage应该是随机挂，可以review了 |
kangguangli
reviewed
Jul 17, 2023
| - op : cast | ||
| inputs : | ||
| x : X | ||
|
|
There was a problem hiding this comment.
需要给output也添加映射
outputs :
out : Out
There was a problem hiding this comment.
legacy_ops.yaml这里需不需要把
- op : cast
args : (Tensor x, DataType dtype)
output : Tensor修改为
- op : cast
args : (Tensor x, DataType dtype)
output : Tensor(out)There was a problem hiding this comment.
应该不需要， @heavyrain-lzy 麻烦帮忙确认下
There was a problem hiding this comment.
在自动生成静态图代码中，如果output如果只有一个且不配置，默认为是out，不影响静态图代码自动生成；如果在new IR也可以这样使用默认配置的话，这里就可以不用修改
kangguangli
reviewed
Jul 17, 2023
|
@gouzil 这两个Op可能特殊点，可以注意比较下它们的xxx_op.cc文件和它们在 |
heavyrain-lzy
approved these changes
Jul 18, 2023
| - op : cast | ||
| inputs : | ||
| x : X | ||
|
|
There was a problem hiding this comment.
在自动生成静态图代码中，如果output如果只有一个且不配置，默认为是out，不影响静态图代码自动生成；如果在new IR也可以这样使用默认配置的话，这里就可以不用修改
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
…ddle#55467) * add cast and repeat_interleave * fix
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
…ddle#55467) * add cast and repeat_interleave * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
添加 cast 和 repeat_interleave 的算子参数映射