[ROCM]:Delete the special target and fix compiler options #55507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime compiler api will only build special target if it is bind.
'--include-path' is not supported by hipcc and "-I/include/folder"
is better choice
fix ut:
* device_code_test
* test_code_generator
* test_fusion_group_pass
* test_fusion_group_op
Signed-off-by: jiajuku <jiajuku12@163.com>
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@luotao1 看上去PR-CI-Windows-OPENBLAS中的fail是matplotlib相关，跟这次提交的代码没什么相关性 |
|
windows的问题正在修复中，可以先把其他流水线过了 |
|
Sorry to inform you that 1a25fd8's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
all CI pass, @luotao1 麻烦安排下review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
去掉rocm gpu target的绑定, 否则jit将会仅仅生成指定target的kernel
'--include-path' is not supported by hipcc on rocm4.5 and 5.0 above
"-I" is better choice
half datatype has been rocm buildin type
fix ut:
* device_code_test
* test_code_generator
* test_fusion_group_pass
* test_fusion_group_op