Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CINN] fix run cinn-ut in paddle with cinn #55530

Merged
merged 5 commits into from Aug 1, 2023

Conversation

6clc
Copy link
Contributor

@6clc 6clc commented Jul 19, 2023

PR types

Others

PR changes

Others

Description

Pcard-72423
修复Paddle With CINN 执行 python单测下op_mapper 时报gflags符号undefined问题。

当前相关Target的依赖关系如下图,因为Paddle Target同时依赖phi.so 和 cinn.so。这个两个动态库不可以同时依赖一个gflags,所以cinn.so不依赖gflags,但执行Paddle Target的时候可以使用phi.so中的gflags。

这样的依赖关系导致CINN Python UT单独使用phi.so的时候没办法找到gflags。
image

通用解法是将gflags转为动态库,工作量较大,考虑CINN后期有使用phi的计划,此PR将cinn.so直接依赖phi.so解决该问题。
依赖图如下。

image

@paddle-bot
Copy link

paddle-bot bot commented Jul 19, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CMakeLists.txt

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 31, 2023

Sorry to inform you that 482225c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit cff7d64 into PaddlePaddle:develop Aug 1, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants