Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in rnn op #55656

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix bugs in rnn op #55656

merged 1 commit into from
Jul 25, 2023

Conversation

cqulilujia
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Description

Fix bugs in xpu kernel of rnn op.

@@ -97,7 +97,7 @@ void RnnKernel(const Context& dev_ctx,

int gate_num = 4;
int hidden_data_idx = (num_layers - 1);
hidden_data_idx += (gate_num + 1) * num_layers;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参照paddle/phi/kernels/cpu/rnn_functor.h 22行

@paddle-bot paddle-bot bot added the contributor External developers label Jul 24, 2023
Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@QingshuChen QingshuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QingshuChen QingshuChen merged commit 0cd422b into PaddlePaddle:develop Jul 25, 2023
27 checks passed
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
jinjidejinmuyan pushed a commit to jinjidejinmuyan/Paddle that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants