Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bf16 black_list and white_list #55713

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

AnnaTrainingG
Copy link
Contributor

@AnnaTrainingG AnnaTrainingG commented Jul 26, 2023

PR types

Others

PR changes

Others

Description

Pcard-70458
Others
统一AMP BF16 与 FP16 的 黑名单和 gray_list,默认白名单未修改

@paddle-bot
Copy link

paddle-bot bot commented Jul 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 3, 2023

Sorry to inform you that 67a476a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@AnnaTrainingG AnnaTrainingG changed the title Set bf16 list Set bf16 black_list and white_list Aug 21, 2023
BF16_WHITE_LIST = {'conv2d', 'einsum', 'matmul_v2'}
BF16_BLACK_LIST = set()
BF16_WHITE_LIST = {'conv2d', 'matmul', 'matmul_v2', 'mul'}
BF16_BLACK_LIST = FP16_BLACK_LIST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

einsum这个应该不能移除,之前是专门加上去的。可以考虑给bf16和fp16的白名单求个并集统一一下,一些历史原因导致没有统一。不过需要注意的白名单中的某些融合算子可能是只支持低精度,或者某种低精度

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@AnnaTrainingG AnnaTrainingG merged commit 9dbc8f0 into PaddlePaddle:develop Aug 25, 2023
26 checks passed
JunnYu added a commit to PaddlePaddle/PaddleMIX that referenced this pull request Aug 31, 2023
PaddlePaddle/Paddle#55713
修改了BF16默认黑白名单导致当前代码会报错。
因此需要手动将layer norm添加bf16 o1白名单

![bd3f6f1c3d576870635f19e8a49f04f6](https://github.com/PaddlePaddle/PaddleMIX/assets/50394665/33d20150-fa49-43c8-b421-e89618ed43ea)
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants