Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old dataloader & generator from quantilization #55754

Merged

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Jul 27, 2023

PR types

Breaking changes

PR changes

APIs

Description

Pcard-67005

The old verison of generated DataLoader (i.e. created by paddle.fluid.io.DataLoader.from_generator) will be deprecated and replaced by iterative version, (i.e. created by paddle.io.DataLoader). But there are still some There are still some modules dependencies on the former one. (Quantization and Auto-Parrallel).

This PR is to remove the dependencies in Quantization. The PostTrainingQuantization will only accept paddle.io.DataLoader.

@paddle-bot
Copy link

paddle-bot bot commented Jul 27, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@yghstill yghstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit e2e0d29 into PaddlePaddle:develop Jul 28, 2023
27 checks passed
@zoooo0820 zoooo0820 deleted the remove_old_dataloader_used_code branch July 28, 2023 08:12
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
…5754)

* remove old dataloader & generator from quantilization

* fix ut test_post_training_quantization_mnist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants