Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cudnn pool3d #5602

Merged
merged 8 commits into from
Nov 20, 2017
Merged

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Nov 13, 2017

fix #4637

  • cudnn_helper.h can be used to process 3D data directly. I only add kNCDHW element and change it's unit test. class DataLayout are not used in current code.
  • I only add register code for pool3d_cudnn_op and unit test.
  • Although there are two interface for tensor descriptor in cudnn (cudnnSetTensorNdDescriptor and cudnnSetTensor4dDescriptor), but the current understanding is that cudnnSetTensorNdDescriptor can replace cudnnSetTensor4dDescriptor, and because it is only a Descriptor, so it is possible that the efficiency of influence is not large (or even negligible).

I'll get a better understanding of the difference between them. If someone know that, please tell me, thx.

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chengduoZH chengduoZH merged commit 134eaf2 into PaddlePaddle:develop Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pool cudnn op
2 participants