add tanh_triple_grad composite logic #56072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Aug 9, 2023
| @@ -72,7 +72,7 @@ | |||
| "subtract_double_grad", | |||
| "add_triple_grad", | |||
| "silu_double_grad", | |||
| "tanh_double_grad", | |||
There was a problem hiding this comment.
Why delete tanh_double_grad?
There was a problem hiding this comment.
When decomposing tanh_triple_grad, the tanh_grad and tanh_double_grad can use fused kernels for better performance, thus remove tanh_double_grad from prim_white_list to prevent decomposing tanh_double_grad redundantly.
lxd-cumt
added a commit
to lxd-cumt/Paddle
that referenced
this pull request
Aug 15, 2023
* decompose tanh_triple_grad and add it into prim_white_list test=develop * fix TanhTripleGradKernel bugs test=develop * decompose tanh_triple_grad test=develop
lxd-cumt
added a commit
to lxd-cumt/Paddle
that referenced
this pull request
Nov 3, 2023
* decompose tanh_triple_grad and add it into prim_white_list test=develop * fix TanhTripleGradKernel bugs test=develop * decompose tanh_triple_grad test=develop
lxd-cumt
added a commit
to lxd-cumt/Paddle
that referenced
this pull request
Nov 3, 2023
* decompose tanh_triple_grad and add it into prim_white_list test=develop * fix TanhTripleGradKernel bugs test=develop * decompose tanh_triple_grad test=develop
XiaoguangHu01
pushed a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
decompose tanh_triple_grad, add tanh_triple_grad into prim_white_list, and fix bugs in TanhTripleGradKernel
Pcard-66975