[dtype] add fp16 support for dist_kernel #56184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Ready for review~ @zhangting2020 |
|
请问之前的实现引起推理精度下降的问题，在这个PR上有做过验证吗？ #53525 |
| } | ||
|
|
||
| private: | ||
| T p_order_; | ||
| Ty p_order; | ||
| }; |
There was a problem hiding this comment.
变量的命名请参考google-cpp-styleguide
| phi::DistGradKernel, | ||
| float, | ||
| double, | ||
| phi::dtype::float16) {} |
There was a problem hiding this comment.
bfloat16也记得注册一下，另外添加对应单测
python/paddle/tensor/linalg.py
Outdated
| x (Tensor): 1-D to 6-D Tensor, its data type is float32 or float64. | ||
| y (Tensor): 1-D to 6-D Tensor, its data type is float32 or float64. | ||
| x (Tensor): 1-D to 6-D Tensor, its data type is float16, float32 or float64. | ||
| y (Tensor): 1-D to 6-D Tensor, its data type is float16, float32 or float64. |
There was a problem hiding this comment.
注册bfloat16类型后，文档记得更新
| ) | ||
| check_variable_and_dtype( | ||
| y, 'dtype', ['float16', 'float32', 'float64'], 'dist' | ||
| ) |
比较尴尬，手上没有Turing及以前架构的卡，重新编一个Ampare的可行吗？ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Description
refer to #50915