Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] No.34,36 enable performance-noexcept-move-constructor,modernize-use-transparent-functors #56261

Merged
merged 17 commits into from Sep 1, 2023
Merged

[clang-tidy] No.34,36 enable performance-noexcept-move-constructor,modernize-use-transparent-functors #56261

merged 17 commits into from Sep 1, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Aug 14, 2023 •
edited

PR types

Others

PR changes

Others

Description

enable performance-noexcept-move-constructor
enable modernize-use-transparent-functors

@paddle-bot
Copy link

paddle-bot bot commented Aug 14, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 14, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 14, 2023
@luotao1 luotao1 mentioned this pull request Aug 14, 2023
Open
@enkilee enkilee changed the title [clang-tidy] No.34 enable performance-noexcept-move-constructor [clang-tidy] No.34 and 36 enable performance-noexcept-move-constructor,modernize-use-transparent-functors Aug 17, 2023
@enkilee enkilee changed the title [clang-tidy] No.34 and 36 enable performance-noexcept-move-constructor,modernize-use-transparent-functors [clang-tidy] No.34,36 enable performance-noexcept-move-constructor,modernize-use-transparent-functors Aug 17, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 25, 2023

Sorry to inform you that 3c12638's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@enkilee
Copy link
Contributor Author

enkilee commented Aug 28, 2023

@zhangbo9674 please review this pr if u are free, thx.

zhangbo9674
zhangbo9674 previously approved these changes Aug 29, 2023
View reviewed changes
@luotao1
Copy link
Contributor

luotao1 commented Aug 29, 2023

请解决下冲突

@luotao1 luotao1 merged commit 17e4be2 into PaddlePaddle:develop Sep 1, 2023
25 of 26 checks passed
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@enkilee @BeingGod
[clang-tidy] No.34,36 enable performance-noexcept-move-constructor,mo…
fc54b40 
…dernize-use-transparent-functors (PaddlePaddle#56261)

* fix

* fix

* CI

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* CI

* fix

* CI
@enkilee enkilee deleted the clangtidy_36 branch December 19, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 left review comments

Assignees

@luotao1 luotao1

@GreatV GreatV

@zhangbo9674 zhangbo9674

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@enkilee @luotao1 @zhangbo9674 @GreatV