Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneDNN] cpu_quantize_pass fix #56303

Merged
merged 21 commits into from
Aug 21, 2023

Conversation

zhanglirong1999
Copy link
Contributor

@zhanglirong1999 zhanglirong1999 commented Aug 15, 2023

PR types

Bug fixes

PR changes

Others

Description

In MobileNetV2 unit test, there is an error of Attribute fuse_alpha is not found. We found during upgrade OneDNN v3, we use fuse_beta in relu6, there is no need to multi scale_out to get fuse_alpha. So the related code can be removed. And the unit test has been passed.

@paddle-bot
Copy link

paddle-bot bot commented Aug 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 15, 2023
@paddle-bot
Copy link

paddle-bot bot commented Aug 15, 2023

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@YangQun1 YangQun1 added the Intel label Aug 15, 2023
@zhanglirong1999 zhanglirong1999 force-pushed the cpu_quantize_pass_fix branch 10 times, most recently from cacfdc6 to 0b3d693 Compare August 17, 2023 02:59
@zhanglirong1999 zhanglirong1999 force-pushed the cpu_quantize_pass_fix branch 2 times, most recently from fea2f85 to 622e67a Compare August 17, 2023 04:22
@xinyu-intel
Copy link
Contributor

@vivienfanghuagood Hi, can you please take a review on this PR?

Copy link
Contributor

@vivienfanghuagood vivienfanghuagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivienfanghuagood vivienfanghuagood removed the request for review from qingqing01 August 18, 2023 07:57
@heavengate heavengate merged commit db4ae6e into PaddlePaddle:develop Aug 21, 2023
26 checks passed
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants