【New IR] Concat python api and vjp #56316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… upstream/czy-gen
… upstream/czy-gen
…to upstream/czy-gen
… support_prim_in_new_ir
Aurelius84
approved these changes
Aug 18, 2023
Ligoml
approved these changes
Aug 18, 2023
YuanRisheng
reviewed
Aug 18, 2023
| @@ -1120,6 +1120,10 @@ def concat(x, axis=0, name=None): | |||
| input = [t for t in input if t.shape.count(0) == 0] | |||
| return _C_ops.concat(input, axis) | |||
| else: | |||
| if paddle.ir.core._use_new_ir_api(): | |||
| if not isinstance(input, Variable): | |||
There was a problem hiding this comment.
新IR下传入的input不可能是Variable，这里判断逻辑是不是有问题
There was a problem hiding this comment.
此处下个pr修改为Value
There was a problem hiding this comment.
I approve this PR, But after modification in another PR, please write the PR number here.
xiaoguoguo626807
merged commit 1da20aa
into
PaddlePaddle:develop
24 of 26 checks passed
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
* support ir api form prim * convert vector of int to intarray * support ir api for prim * Add more gen api * concat python api to concat_grad * fix gen conflict * support vjp prim mode in new ir * remove useless code * add vjp autogen v1.0 * add test for prim * resolve type conflict * modify utils * remove useless code * add split op and modify some bug of vectorType * fix conflict * add concat python test --------- Co-authored-by: cyber-pioneer <chenzhuo@tju.edu.cn> Co-authored-by: Charles-hit <wanghao107@baidu.com> Co-authored-by: 0x45f <wangzhen45@baidu.com> Co-authored-by: chenzhiyang <1792266893@qq.com> Co-authored-by: Chen Zhiyang <chenzhiyang99@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
1.补充concat python api 到 concat_vjp 全部调用层代码，涉及可变attribute； vectorType 特殊处理
2.补充builtin_split op定义及执行前处理函
3.增加backward相关测试样例，验证concat 构建过程
pcard-67164