Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openssl1.1.1 problem #56366

Merged
merged 15 commits into from Aug 22, 2023
Merged

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented Aug 16, 2023

PR types

Bug fixes

PR changes

Others

Description

  • 背景:
    PR50791之前为了在镜像里打入python3.10,python3.11,将镜像里的Openssl从1.0.2升级到1.1.1会导致一些本地openssl不是1.1.1的用户在import paddle时候报错如下:
    image

  • 导致的问题

升级之后libpaddle.so依赖了libssl.so1.1.1和libcrypto.so
9a930b555834dd4914e80b8b90f0e4c6

  • 原因
    第三方库第三方库brpc.cmake中find_package(OPENSSL)在openssl1.0.2时得到的是静态库,升级为1.1.1后得到的是动态库libssl.so,故导致libpaddle.so link了libssl.so

  • 解决办法:
    解除依赖,用find_library找到libssl.a和libcrypto.a代替libssl.so和libcrypto.so

@paddle-bot
Copy link

paddle-bot bot commented Aug 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Aug 16, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 422a565 into PaddlePaddle:develop Aug 22, 2023
26 checks passed
risemeup1 added a commit that referenced this pull request Aug 22, 2023
risemeup1 added a commit that referenced this pull request Aug 22, 2023
risemeup1 added a commit that referenced this pull request Sep 5, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
* fix openssl bug

* fix openssl bug

* fix openssl bug

* test

* upgrade openssl version

* fix

* fix

* update

* fix openssl bug

* fix

* Update ci_dockerfile.sh

---------

Co-authored-by: YUNSHEN XIE <1084314248@qq.com>
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
risemeup1 added a commit that referenced this pull request Sep 9, 2023
* Revert "Revert "Fix  openssl1.1.1 problem (#56366)" (#56545)"

This reverts commit 7452d53.

* fix openssl bug

* Update paddle_coverage.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants