add is empty op #5639
Merged
add is empty op #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddle/operators/is_empty_op.cc
Outdated
| IsEmptyOpProtoMaker(framework::OpProto *proto, | ||
| framework::OpAttrChecker *op_checker) | ||
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput("X", "the tensor to check whether is empty"); |
There was a problem hiding this comment.
It will be good to adher to the naming convention for operators. https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/name_convention.md
jacquesqiao
reviewed
Nov 15, 2017
paddle/operators/is_empty_op.cc
Outdated
| PADDLE_ENFORCE_NOT_NULL(out); | ||
| auto *out_tensor = out->GetMutable<framework::LoDTensor>(); | ||
|
|
||
| out_tensor->Resize(framework::make_ddim(std::vector<int>({1}))); |
There was a problem hiding this comment.
can use
out_tensor->Resize({1});instead
paddle/operators/is_empty_op.cc
Outdated
| IsEmptyOpProtoMaker(framework::OpProto *proto, | ||
| framework::OpAttrChecker *op_checker) | ||
| : OpProtoAndCheckerMaker(proto, op_checker) { | ||
| AddInput(kInput, "the tensor to check whether is empty"); |
There was a problem hiding this comment.
Sorry for not being clear last time. I was referring to the Input and the Output comments. We can write this as
AddInput(kInput, "(Tensor) Tensor which is to be checked");
We can do similar for Output.
Sorry for not being clear last time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5627