Fix conv2d bias #5651
Merged
Fix conv2d bias #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emailweixu
commented
Nov 15, 2017
emailweixu
commented
- The size of the bias parameter should be the number of filters. Changed LayerHelper.append_bias_op to allow this kind of bias.
- Also change the default initialization of bias to be constant zero
- Added a helper to get the value of a parameter.
- Updated test_parameter
The size of the bias parameter should be the number of filters.
jacquesqiao
reviewed
Nov 15, 2017
python/paddle/v2/fluid/layers.py
Outdated
| @@ -676,6 +676,7 @@ def conv2d(input, | |||
| filter_shape = [num_filters, num_filter_channels] + filter_size | |||
|
|
|||
| std = (2.0 / (filter_size[0]**2 * num_channels))**0.5 | |||
| print 'name=', name, 'std=', std | |||
There was a problem hiding this comment.
this debug code should be removed
jacquesqiao
reviewed
Nov 15, 2017
python/paddle/v2/fluid/io.py
Outdated
| if program is None: | ||
| program = g_main_program | ||
| var = program.global_block().var(name) | ||
| assert is_parameter(var) |
There was a problem hiding this comment.
should move this assert into get_parameter_value
emailweixu
force-pushed
the
fix_conv_bias
branch
from
0ff1d26
to
d8bf343
Compare
emailweixu
force-pushed
the
fix_conv_bias
branch
from
d8bf343
to
81bb26f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.