Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【complex op】No.7 add complex support for isclose #56723

Merged
merged 8 commits into from Aug 31, 2023
Merged

【complex op】No.7 add complex support for isclose #56723

merged 8 commits into from Aug 31, 2023

Conversation

jinyouzhi
Copy link
Contributor

@jinyouzhi jinyouzhi commented Aug 28, 2023 •
edited by luotao1

PR types

New features

PR changes

OPs

Description

@paddle-bot
Copy link

paddle-bot bot commented Aug 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Aug 28, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 28, 2023
@luotao1 luotao1 mentioned this pull request Aug 28, 2023
Closed
@jinyouzhi
Copy link
Contributor Author

jinyouzhi commented Aug 30, 2023 •
edited

@GGBond8488 @ScottWong98 pls help review

ScottWong98
ScottWong98 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@ScottWong98 ScottWong98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GGBond8488
GGBond8488 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@GGBond8488 GGBond8488 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

记得同样改一下中文文档的数据类型

@luotao1
Copy link
Contributor

luotao1 commented Aug 31, 2023

image @jinyouzhi 下一个PR改一下示例代码格式吧，就是xdoctest的方式。

@luotao1 luotao1 merged commit d53972f into PaddlePaddle:develop Aug 31, 2023
25 of 26 checks passed
@jinyouzhi
Copy link
Contributor Author

image @jinyouzhi 下一个PR改一下示例代码格式吧，就是xdoctest的方式。

不瞒您说，我还真去看过logic.py的xdoctest，@enkilee 佬已经改了但还没提pr

@jinyouzhi jinyouzhi deleted the isclose_complex branch August 31, 2023 11:56
@jinyouzhi jinyouzhi mentioned this pull request Aug 31, 2023
Merged
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Sep 6, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@jinyouzhi @BeingGod
【complex op】No.7 add complex support for isclose (PaddlePaddle#56723)
b2b81db 
* add complex support for isclose

* add complex test for isclose

* fix template complie issue

* fix cuda compilation error

* fix type typo

* fix error for complex's abs

* add complex dtype into input

* fix ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@GGBond8488 GGBond8488 GGBond8488 approved these changes

@ScottWong98 ScottWong98 ScottWong98 approved these changes

Assignees

@luotao1 luotao1

@GGBond8488 GGBond8488

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jinyouzhi @luotao1 @GGBond8488 @ScottWong98