[OneDNN] Fix v3.2 conv dst layout cause regression case performance declined issue #56782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhanglirong1999
force-pushed
the
onednn3.1_conv_nhwc
branch
from
c2662de
to
cd4a326
Compare
xinyu-intel
previously approved these changes
Sep 5, 2023
YangQun1
previously approved these changes
Sep 5, 2023
zhanglirong1999
dismissed stale reviews from YangQun1 and xinyu-intel
via
222944f
zhanglirong1999
force-pushed
the
onednn3.1_conv_nhwc
branch
from
cd4a326
to
222944f
Compare
xinyu-intel
approved these changes
Sep 8, 2023
YangQun1
approved these changes
Sep 8, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Since v3.2 changed the conv ic=3 dst layout from nhwc to nchw16c, cause the mixture overhead for the following binary primitive in regression case. We decide to fix it by manually switch dst layout.