[Reshard] reshard from partial to replicated in same placement #56975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LiYuRio
force-pushed
the
dev_p_to_r
branch
3 times, most recently
from
da63862
to
2cf5e78
Compare
XieYunshen
approved these changes
Sep 8, 2023
JZ-LIANG
approved these changes
Sep 8, 2023
| errors::InvalidArgument( | ||
| "Partial axis %ld can not exceed the ndim of process_mesh %ld", | ||
| itr.first, | ||
| ndim)); |
There was a problem hiding this comment.
could be better to double check here that the dim to partial is not be used as sharded.
| "Split axis %ld can not exceed the ndim of process_mesh %ld", | ||
| dims_mapping_[i], | ||
| ndim)); | ||
| placement[dims_mapping_[i]] = std::make_shared<ShardStatus>(i); |
There was a problem hiding this comment.
why shared_ptr ？ the return placement is supposed for temporary usage and should not be hold by others.
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-73145
Reshard方面：
丰富语义：