Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logical operators for beam search and control flow #5708

Merged
merged 1 commit into from
Nov 18, 2017

Conversation

abhinavarora
Copy link
Contributor

No description provided.

Copy link
Collaborator

@emailweixu emailweixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need unittest under fluid/tests

@abhinavarora
Copy link
Contributor Author

@emailweixu The tests are there in python/paddle/v2/fluid/tests/test_logical_op.py
Is there any specific test you are requesting? Please let me know.

@emailweixu
Copy link
Collaborator

@abhinavarora sorry, didn't find it at first.

@emailweixu emailweixu dismissed their stale review November 16, 2017 19:19

sorry, didn't find it at first.

Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinavarora abhinavarora merged commit 6cfcf62 into PaddlePaddle:develop Nov 18, 2017
@abhinavarora abhinavarora deleted the logical_op branch November 18, 2017 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants