Optimize the calling logic of the cast and cast_grad kernels to reduce compilation size #57083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
reviewed
Sep 7, 2023
| CastCUDAKernelImpl<T, data_t>( | ||
| dev_ctx, out_grad, x_grad->dtype(), x_grad); | ||
| })); | ||
| CastImpl<T, Context>(dev_ctx, out_grad, x_grad->dtype(), x_grad); |
There was a problem hiding this comment.
这样还是会编译2份吧？能直接调phi::CastKernel吗？
Xreki
reviewed
Sep 12, 2023
paddle/phi/kernels/gpu/cast_impl.h
Outdated
| } | ||
|
|
||
| template <typename T, typename Context> | ||
| void CastKernel(const Context& dev_ctx, |
There was a problem hiding this comment.
CastKernel实现不用挪到头文件中，在cast_kernel.cu里面实现就行，cast_grad_kernel.cu里面只需include cast_kernel.h
AnnaTrainingG
force-pushed
the
compile_4_1
branch
2 times, most recently
from
3dc24d2
to
e55c537
Compare
Xreki
reviewed
Sep 13, 2023
| CastCUDAKernelImpl<T, data_t>( | ||
| dev_ctx, out_grad, x_grad->dtype(), x_grad); | ||
| })); | ||
| CastKernel<T, Context>(dev_ctx, out_grad, x_grad->dtype(), x_grad); |
There was a problem hiding this comment.
我觉得这里传x.dtype()比较合适。x_grad是输出，其实它的数据类型在Alloc之前是没有确定的，后面也会重置（cast_impl.h里面的第39行out->set_type(out_dtype);）。
AnnaTrainingG
force-pushed
the
compile_4_1
branch
from
e55c537
to
6871280
Compare
AnnaTrainingG
changed the title
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…e compilation size (PaddlePaddle#57083)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-70459
compile test 4.1
体积变化：