Compilation optimization for broadcast #57118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
niuliling123
previously approved these changes
Sep 15, 2023
Xreki
reviewed
Sep 15, 2023
| std::vector<phi::DenseTensor*> mul_outputs = {&equal_out_tensor}; | ||
| funcs::BroadcastKernel<T>( | ||
| dev_ctx, mul_inputs, &mul_outputs, funcs::MultiplyFunctor<T>(), 0); | ||
| phi::MultiplyKernel<T, Context>( |
There was a problem hiding this comment.
以文件为单位修改吧，我看这个文件里面还有别的BroadcastKernel调用
Xreki
approved these changes
Sep 22, 2023
| phi::SumKernel<T, Context>(dev_ctx, | ||
| equal_out_tensor, | ||
| reduce_dims, | ||
| equal_out_tensor.dtype(), |
There was a problem hiding this comment.
这个参数是out_dtype，应该设置成equal_count的dtype
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* Compilation optimization for broadcast * replaced ReduceKernel with SumKernel
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* Compilation optimization for broadcast * replaced ReduceKernel with SumKernel
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* Compilation optimization for broadcast * replaced ReduceKernel with SumKernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Description
Pcard-70459
kernel编译体积优化--kernel类型：broadcast