[PRIM][PIR]Support no grad in vjp #57294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| std::vector<std::vector<Tensor>> ConstructVjpResultByStopGradients( | ||
| const std::vector<std::vector<Tensor>>& outputs, | ||
| const std::vector<std::vector<bool>>& stop_gradients) { | ||
| SetOutputWithNoGrads(outputs, stop_gradients); |
There was a problem hiding this comment.
stop_gradients=true 和 no_grad语义不是一个意思吧，set_empty_type 是代表什么
There was a problem hiding this comment.
这儿应该是前向stop_gradient来表示创不创建反向变量，ir层面是一定会创建，这个函数名改成SetEmptyGrad吧，表示这个变量应该是空的，set_empty_type在ir中就是表示这个变量为空。
Aurelius84
reviewed
Sep 14, 2023
| @@ -21,9 +21,34 @@ void set_output<LazyTensor>(const paddle::Tensor& x_tmp, paddle::Tensor* x) { | |||
| x->set_impl(x_tmp.impl()); | |||
| } | |||
|
|
|||
| /** | |||
| * @brief set output with no grads in new ir. | |||
There was a problem hiding this comment.
Suggested change
| * @brief set output with no grads in new ir. | |
| * @brief set output with no grads in pir. |
| /** | ||
| * @brief set output with no grads in new ir. | ||
| * | ||
| * In new ir, we use None type to express |
There was a problem hiding this comment.
Suggested change
| * In new ir, we use None type to express | |
| * In pir, we use None type to express |
Aurelius84
approved these changes
Sep 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-66975
support no grad in vjp.