[NewComm]No.7 compatiable upgrade for global_gather_op. #57305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| auto send_buf = x->data<T>(); | ||
| auto recv_buf = out->mutable_data<T>(out_dims, place); | ||
|
|
||
| out->mutable_data<T>(out_dims, place); | ||
|
|
||
| for (auto i = 0; i < n_expert; ++i) { | ||
| PADDLE_ENFORCE_GPU_SUCCESS(platform::dynload::ncclGroupStart()); |
There was a problem hiding this comment.
参考PR：#56088 的alltoall_op.cu.cc修改一下
| j, | ||
| comm->comm(), | ||
| stream)); | ||
| } | ||
| } | ||
| } | ||
| PADDLE_ENFORCE_GPU_SUCCESS(platform::dynload::ncclGroupEnd()); |
| @@ -38,6 +38,15 @@ def test_global_gather_nccl_dygraph_eager(self): | |||
| eager_mode=True, | |||
| ) | |||
|
|
|||
| def test_global_gather_nccl_new_comm(self): | |||
There was a problem hiding this comment.
还需要修改collective_global_gather.py。可以参考#57161
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description