Support many data types of several operators #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Nov 17, 2017
| @@ -22,6 +22,9 @@ namespace math { | |||
|
|
|||
| template class ContextProjectFunctor<platform::GPUPlace, float>; | |||
| template class ContextProjectFunctor<platform::GPUPlace, double>; | |||
| template class ContextProjectFunctor<platform::GPUPlace, int>; | |||
| template class ContextProjectFunctor<platform::GPUPlace, int64_t>; | |||
| template class ContextProjectFunctor<platform::GPUPlace, bool>; | |||
There was a problem hiding this comment.
ContextProjectFunctor is not exposed to user, it is used in sequence_conv_op. It seems there is no need to define int, int64_t, bool type for this functor.
Add, sequence_conv_op needs to register double type.
There was a problem hiding this comment.
Done. make sequence_conv_op supports multiple precision.
reyoung
force-pushed
the
feature/support_mix_datatype
branch
from
608d2e7
to
bddf7e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.