[Reshard] Support reshard on nd mesh with same placement #57432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiYuRio
force-pushed
the
dev_reshard
branch
2 times, most recently
from
4d20565
to
b54fe48
Compare
LiYuRio
force-pushed
the
dev_reshard
branch
from
b54fe48
to
a192bb1
Compare
chenwhql
approved these changes
Sep 19, 2023
| for (int64_t i = 0; i < shape_of_axis; ++i) { | ||
| coord[axis] = i; | ||
| int64_t rank = coord.back(); | ||
| for (int64_t j = coord.size() - 2; j >= 0; --j) { |
There was a problem hiding this comment.
如果传入的mesh是乱序的，这里的倍数关系也没问题吗，比如[[2,5], [6,1], [4, 7], [3, 0]]
There was a problem hiding this comment.
确实有点问题，缺了一步根据下标再去mesh里取对应的id。在这个例子里，假如当前全局rank是7，用GetCurRankCoordInMesh函数获取到它在mesh中的坐标是(2, 1)，如果要获取的是第0维的子mesh，那和它在一个组的是(0, 1), (1, 1), (2, 1), (3, 1)；如果要获取第1维的子mesh，和它在同一个组的是(2, 0)和(2, 1)，然后根据下标和mesh的shape，相乘得到对应的下标，然后再取下标对应的process_id
XieYunshen
approved these changes
Sep 19, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-73145
本PR主要支持了高维但相同mesh下不同状态间的转换，用于支持DP+MP混合并行场景。单测只为覆盖率，因为两卡不能测试全高维mesh，本地测过8卡。工作原理：
TODO：
顺便，修复高版本python下（3.9），launch的log重复打印两次的问题。