Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR]Add constraint function for dynamic shape #57459

Merged
merged 9 commits into from
Sep 20, 2023
Merged

[PIR]Add constraint function for dynamic shape #57459

merged 9 commits into from
Sep 20, 2023

Conversation

liuruyan
Copy link
Contributor

@liuruyan liuruyan commented Sep 18, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

  1. 增加 buildShape 功能：为 program 中 TensorShape 绑定 SymbolicDim。
  2. 增加 applyOpConstraint 功能：根据 Op 类型对其 Value 附着的 SymbolicDim 添加约束关系。
  3. 更正 shape.FuncOp 的打印格式。并将 DenseTensorType 中维度为动态时，打印 「 ？」
  4. 统一代码格式，getLhs() => lhs()

TODO:

  1. 在 buildShape 前增加规范化 pattern rewrite。
  2. 在 applyOpConstraint 中添加更多约束关系。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 18, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@liuruyan liuruyan changed the title Add buildShape function for DynamicShape Add constraint function for dynamic shape Sep 19, 2023
@Aurelius84 Aurelius84 changed the title Add constraint function for dynamic shape [PIR]Add constraint function for dynamic shape Sep 20, 2023
winter-wang
winter-wang approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

paddle/pir/dialect/shape/utils/shape_utils.cc Show resolved Hide resolved
paddle/pir/dialect/shape/utils/shape_utils.cc Show resolved Hide resolved
paddle/pir/dialect/shape/utils/shape_utils.cc Show resolved Hide resolved
paddle/pir/dialect/shape/utils/shape_utils.cc Show resolved Hide resolved
test/cpp/pir/shape_dialect/symbolic_op_test.cc Show resolved Hide resolved
zhangbopd
zhangbopd approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@zhangbopd zhangbopd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangbopd zhangbopd merged commit cf94055 into PaddlePaddle:develop Sep 20, 2023
27 checks passed
@liuruyan liuruyan deleted the buildShape_ branch September 20, 2023 07:23
iosmers pushed a commit to iosmers/Paddle that referenced this pull request Sep 21, 2023
@liuruyan
[PIR]Add constraint function for dynamic shape (PaddlePaddle#57459)
08947ac 
* build shape.

* add applyOpConstraint func
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
@liuruyan @Frida-a
[PIR]Add constraint function for dynamic shape (PaddlePaddle#57459)
547465f 
* build shape.

* add applyOpConstraint func
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@liuruyan
[PIR]Add constraint function for dynamic shape (PaddlePaddle#57459)
bd955e0 
* build shape.

* add applyOpConstraint func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbopd zhangbopd zhangbopd approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@winter-wang winter-wang winter-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuruyan @Aurelius84 @winter-wang @zhangbopd