Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneDNN] fix fast_rcnn bug #57598

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

zhanglirong1999
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fast RCNN unit test will failed when open MKLDNN. Since primitive will create failed when input tensor dims is 0. We need to manual set to 1 to create oneDNN primitive

@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 21, 2023
@zhanglirong1999 zhanglirong1999 changed the title fix fast_rcnn bug [OneDNN] fix fast_rcnn bug Sep 21, 2023
@zhanglirong1999
Copy link
Contributor Author

zhanglirong1999 commented Sep 22, 2023

Fix #57584

@YangQun1
Copy link
Contributor

can we add a unit test for this fix?

@xinyu-intel xinyu-intel merged commit aa692f9 into PaddlePaddle:develop Sep 22, 2023
27 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants