[PIR] register some fused_ops #57655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… register_fused_operations
… register_fused_operations
kangguangli
commented
Sep 27, 2023
| const OpOutputMapping& arg_to_idx) override { | ||
| OpTranscriber::RecordOpResultMapping( | ||
| ctx, param_map, op_desc, operation, arg_to_idx); | ||
| if (op_desc.HasOutput("Out")) { |
There was a problem hiding this comment.
Sometimes, the original fused_feedforward will have two outputs pointing to same variable, which uses same memory buffer.
Paddle/paddle/fluid/framework/ir/fused_feedforward_pass.cc
Lines 188 to 192 in 3ce66d5
After translating, the two outputs will be mapped to two values while having different memory buffers and result in precision problem.
By forcing this duplicate variable mapping to output out only, we can get the right result.
There was a problem hiding this comment.
建议针对该问题添加必要 Warning 日志
zyfncg
previously approved these changes
Sep 27, 2023
Comment on lines
+1262
to
+1263
| dropout1_seed: Dropout1Seed | ||
| dropout2_seed: Dropout2Seed |
There was a problem hiding this comment.
不是，fused_feedforward的kernel参数重既包含dropout1_seed，又包含dropout1_seed_val
XieYunshen
approved these changes
Sep 27, 2023
zyfncg
approved these changes
Sep 28, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* register_fused_ops * add unittest * fix bug and add test * refine * refine * set timeout
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* register_fused_ops * add unittest * fix bug and add test * refine * refine * set timeout
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* register_fused_ops * add unittest * fix bug and add test * refine * refine * set timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
fused_attention_gradin pirfused_feedforwardand its grad op in pirFusedAttentionInfermetafrommultiary.cctofusion.ccby comments in [PIR] register fused_attention in pir #57557Others
Pcard-67164