New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug (conv2d groups: 'num_channels % groups is not 0:' ) #5772

Merged

chengduoZH merged 1 commit into PaddlePaddle:develop from chengduoZH:fix_layer.py.conv2dbug

Nov 20, 2017

Contributor

chengduoZH commented Nov 20, 2017

        if num_channels % groups is not 0:
            raise ValueError("num_channels must be divisible by groups.")
        num_filter_channels = num_channels / groups

This expression( if num_channels % groups is not 0) is wrong, it should be if num_channels % groups != 0


          fix bug (conv2d groups )

3872ea0

chengduoZH requested a review from JiayiFeng

November 20, 2017 05:26

JiayiFeng approved these changes

View reviewed changes

Collaborator

JiayiFeng left a comment

LGTM

chengduoZH merged commit 9db4d01 into PaddlePaddle:develop

chengduoZH deleted the fix_layer.py.conv2dbug branch

January 29, 2018 07:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment