Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semi-Auto] Revise InferShape hack #57742

Merged
merged 6 commits into from Oct 12, 2023

Conversation

JZ-LIANG
Copy link
Contributor

@JZ-LIANG JZ-LIANG commented Sep 26, 2023

PR types

Bug fixes

PR changes

Others

Description

Pcard-70448

  • Revise and remove InferShape Hack in Pararllelizer.
  • Revise and remove InferShape Hack in Matmul Dist Op
  • Improve parallel matmul performance by forcing the allreduce of row parallel inplace.
  • Revise DistAttr print function to print Partial info.

@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Sep 26, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 4, 2023

Sorry to inform you that 03dbbf9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@JZ-LIANG JZ-LIANG changed the title [Semi-Auto] hack2 [Semi-Auto] Revise InferShape hack Oct 10, 2023
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JZ-LIANG JZ-LIANG merged commit 093c6f3 into PaddlePaddle:develop Oct 12, 2023
28 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* inplacae allreduce & revise infershape

* revise infershape in parallerizer

* temp bugfix for dist_context cycle reference
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* inplacae allreduce & revise infershape

* revise infershape in parallerizer

* temp bugfix for dist_context cycle reference
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* inplacae allreduce & revise infershape

* revise infershape in parallerizer

* temp bugfix for dist_context cycle reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants