Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Migrate paddle.round into pir #58005

Merged
merged 6 commits into from Oct 17, 2023

Conversation

MarioLulab
Copy link
Contributor

@MarioLulab MarioLulab commented Oct 11, 2023

PR types

Others

PR changes

Others

Description

新 IR API 推全升级
paddle.round 迁移升级至 new ir,并更新单测

单测覆盖率:6/6

@paddle-bot
Copy link

paddle-bot bot commented Oct 11, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 11, 2023
0x45f
0x45f previously approved these changes Oct 13, 2023
Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f closed this Oct 13, 2023
@0x45f 0x45f reopened this Oct 13, 2023
@0x45f
Copy link
Contributor

0x45f commented Oct 13, 2023

组内同学正在修改check_new_ir参数的名字,改动较多,等待 #58071 合入后解决下冲突再合入本PR~

@0x45f
Copy link
Contributor

0x45f commented Oct 16, 2023

#58071 已经合入了,辛苦解决下冲突,把check_new_ir修改为check_pir~

@0x45f
Copy link
Contributor

0x45f commented Oct 16, 2023

我看代码中还有check_new_ir,辛苦都修改为check_pir~

test/mkldnn/test_activation_mkldnn_op.py Outdated Show resolved Hide resolved
test/mkldnn/test_activation_mkldnn_op.py Outdated Show resolved Hide resolved
test/mkldnn/test_activation_mkldnn_op.py Outdated Show resolved Hide resolved
test/mkldnn/test_activation_mkldnn_op.py Outdated Show resolved Hide resolved
@MarioLulab MarioLulab requested a review from 0x45f October 17, 2023 01:35
Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 2bcb871 into PaddlePaddle:develop Oct 17, 2023
28 checks passed
@MarioLulab MarioLulab deleted the luqi/pir_api_round branch October 17, 2023 02:31
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants