Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] Verify auto parallel in amp mode #58172

Merged
merged 5 commits into from Oct 19, 2023

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Oct 17, 2023

PR types

New features

PR changes

Others

Description

Pcard-73145

[AutoParallel] Verify auto parallel in amp mode

在结合AMP验证的过程发现几处问题,进行了修复:

  1. multiply的算子动态图实现是手写的,需要手动添加动半逻辑
  2. dist attr判空需要dims_mapping不为空,但当输入是0-D Tensor时判断条件有误,需进行调整
  3. DistTensor没有_share_data_with接口,在amp O2时需要调用

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 648f3c4 into PaddlePaddle:develop Oct 19, 2023
28 checks passed
hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
* add amp test

* support apm o1 mode

* add share_data_with method for dist tensor
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
* add amp test

* support apm o1 mode

* add share_data_with method for dist tensor
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* add amp test

* support apm o1 mode

* add share_data_with method for dist tensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants